fix: skip Stepwise runtime when disabled - #1551
Open
DamienZCollins wants to merge 2 commits into
Open
Conversation
Owner
|
维护者审查：当前改动的功能逻辑没有发现 blocker。disabled bundle 不包含 Stepwise runtime，enabled 时在 但分支目前与 |
Owner
|
Codex++ maintainer review note 当前 main 下这个 PR 仍存在 merge conflict，暂时不能合并。请先 rebase 到最新 main 并解决冲突；更新后我们会重新跑针对性测试再复审。 This PR currently conflicts with main, so it is not mergeable yet. Please rebase onto the latest main and resolve the conflicts, then we can review and test it again. |
DamienZCollins
force-pushed
the
fix/stepwise-disabled-injection
branch
from
August 4, 2026 04:04
ee3bf49 to
03304e9
Compare
Author
|
已 rebase 到当前
完整 GitHub 已创建 PR build artifacts run，但当前为 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codexAppStepwiseEnabledis enabled.Validation
cargo fmt --checkcargo test -p codex-plus-core --test cdp_bridge injection_script_(47 passed)cargo test -p codex-plus-core --test cdp_bridge stepwise_(10 passed)npm run checkinapps/codex-plus-managercargo build -p codex-plus-launcher --releasecargo test -p codex-plus-core --test cdp_bridge(96/97 passed)Notes
The only full-suite failure is
list_targets_can_query_ipv6_loopback_cdp_endpoint, which cannot bind/query IPv6 loopback in this Windows environment (WSAEACCES 10013). It is independent of this change. The manager dependency audit reports three existing lockfile dependency advisories; no dependency files were changed.Fixes #1549